pass cqe->flags with MsgRingData
#248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quininer
requested changes
Dec 22, 2023
quininer
reviewed
Dec 23, 2023
src/opcode.rs
Outdated
| @@ -1447,15 +1447,14 @@ opcode! { | |||
| let MsgRingData { ring_fd, result, user_data, user_flags, opcode_flags } = self; | |||
|
|
|||
| let mut sqe = sqe_zeroed(); | |||
| sqe.opcode = Self::CODE; | |||
| sqe.__bindgen_anon_2.addr = sys::IORING_MSG_DATA.into(); | |||
| sqe.opcode = Self::CODE; sqe.__bindgen_anon_2.addr = sys::IORING_MSG_DATA.into(); | |||
There was a problem hiding this comment.
There seems to be a line break missing here.
There was a problem hiding this comment.
Sorry. It seems like RustRover has some formatting problems in that file.
It removed all line breaks in my previous commit as well and I forgot to check this time.
bits0rcerer
force-pushed
the
msg_ring_pass_flags
branch
from
a184186
to
173c1bf
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to pass
cqe->flagswithMsgRingData.based on: axboe/liburing.